D16470: [WIP] Make incoming packet handling multi-threaded

Simon Redman noreply at phabricator.kde.org
Mon Oct 29 15:58:16 GMT 2018


sredman added a comment.


  In D16470#350525 <https://phabricator.kde.org/D16470#350525>, @albertvaka wrote:
  
  > I would try to avoid the complexity of managing threads, unless there is a clear advantage or issue fixed by this. Has the current implementation given any problems to you?
  
  
  The issue I was facing is that I needed to be able to block within a dbus call while waiting for the phone to handle a request and return the requested data. Blocking in the dbus call would mean there was no way to handle the incoming packet from the phone
  
  Putting packet handling on its own thread would solve this problem for all plugins, but it would be a huge amount of effort. I have solved it by using a thread in the ConversationDbusInterface. See D16475 <https://phabricator.kde.org/D16475>
  
  If we feel more effort in this direction is worthwhile, this patch is a start. It's more effort than I want to deal with right now, though

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16470

To: sredman, #kde_connect
Cc: albertvaka, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181029/00bd7851/attachment.html>


More information about the KDEConnect mailing list