D16473: Use runWithPlugin helper in SharePlugin

Albert Vaca Cintora noreply at phabricator.kde.org
Mon Oct 29 13:58:10 GMT 2018


albertvaka accepted this revision.
albertvaka added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ShareActivity.java:154
> -                Device device = service.getDevice(deviceId);
> -                if (device.isReachable() && device.isPaired()) {
> -                    SharePlugin.share(intent, device);

This check got removed. I guess it's intended, but just making sure you are aware of the change.

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  refactorShare

REVISION DETAIL
  https://phabricator.kde.org/D16473

To: nicolasfella, #kde_connect, albertvaka
Cc: albertvaka, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181029/eb40d72e/attachment.html>


More information about the KDEConnect mailing list