D15979: [SMS App] Allow scrolling up to load and display older messages

[Simon Redman]

sredman marked 3 inline comments as done.
sredman added a comment.


  There is something really strange going on here. It looks like I accidentally uploaded an older patch 😬 
  This one is actually incompatible with D16475 <https://phabricator.kde.org/D16475> 😬 . Yet I suppose it was working for you guys...
  I will upload the version I meant to upload in a second. This time I will double-check my patch.

INLINE COMMENTS

> apol wrote in conversationsdbusinterface.cpp:69
> Use `m_conversations.value(conversationID)`. Otherwise, if conversationId doesn't exist, it will create the entry and leave it empty.

This is actually fixed in D16475 <https://phabricator.kde.org/D16475>

> apol wrote in smsplugin.cpp:80
> Why this change?

Because some places we had ints (specifically, this is how Android stores the value) and some places we had strings. It was a bit of a pain for me to remember which went where, so I declared everything should be int. Declaring everything should be string would be just as valid
However, that change was actually made in D16475 <https://phabricator.kde.org/D16475>

> apol wrote in smsplugin.h:113
> Would it be very hard to just do it now?

I am actually working on this right now. I hope it is not too difficult

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D15979

To: sredman, #kde_connect, apol
Cc: apol, nicolasfella, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181029/9a71acf5/attachment.html>