D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> requestconversationworker.h:34
> + */
> +class RequestConversationWorker : public QObject
> +{

Two things:
Do we still need threads now that we don't have the QEventLoop? I don't think so.
If we did, maybe it would be useful if this class inherited QThread.

> smsplugin.cpp:105
> +    QList<ConversationMessage> messagesList;
>  
>      for (const QVariant& body : messages) {

messagesList.reserve(messages.count());

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16475

To: sredman, #kde_connect
Cc: apol, nicolasfella, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181028/0ea5233a/attachment-0001.html>