D16475: [SMS App] Make requestMoreMessages asynchronous and caching

Simon Redman noreply at phabricator.kde.org
Sun Oct 28 16:26:17 GMT 2018


sredman updated this revision to Diff 44359.
sredman added a comment.


  - Only send conversationUpdated if the conversation was truly updated
  - Add requestConversationWorker
  - Add blocking to wait for reply from remote device
  
  I also got carried away and changed all QString conversationIDs to qint32. It was too much of a mess to un-tangle by the time I was finished... Sorry!

REPOSITORY
  R224 KDE Connect

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16475?vs=44340&id=44359

BRANCH
  asynchonous-message-fetch

REVISION DETAIL
  https://phabricator.kde.org/D16475

AFFECTED FILES
  plugins/sms/CMakeLists.txt
  plugins/sms/conversationsdbusinterface.cpp
  plugins/sms/conversationsdbusinterface.h
  plugins/sms/requestconversationworker.cpp
  plugins/sms/requestconversationworker.h
  plugins/sms/smsplugin.cpp
  plugins/sms/smsplugin.h
  smsapp/conversationmodel.cpp
  smsapp/conversationmodel.h
  smsapp/qml/ConversationDisplay.qml

To: sredman, #kde_connect
Cc: nicolasfella, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181028/5cb583aa/attachment-0001.html>


More information about the KDEConnect mailing list