D16475: [SMS App] Make requestMoreMessages asynchronous and caching
Simon Redman
noreply at phabricator.kde.org
Sun Oct 28 07:01:36 GMT 2018
sredman created this revision.
sredman added a reviewer: KDE Connect.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
sredman requested review of this revision.
REVISION SUMMARY
Attempts to make requestMoreMessages synchronous were highly unsuccessful. Therefore, I have moved the useful changes from those efforts to this patch
TEST PLAN
After applying this diff, the messaging app should show all messages in the conversation when the conversation is first loaded, and should show the first 10 on all subsequent showings
REPOSITORY
R224 KDE Connect
BRANCH
asynchonous-message-fetch
REVISION DETAIL
https://phabricator.kde.org/D16475
AFFECTED FILES
plugins/sms/conversationsdbusinterface.cpp
plugins/sms/conversationsdbusinterface.h
plugins/sms/smsplugin.cpp
plugins/sms/smsplugin.h
smsapp/conversationmodel.cpp
smsapp/conversationmodel.h
To: sredman, #kde_connect
Cc: kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181028/6031493d/attachment.html>
More information about the KDEConnect
mailing list