D16469: Make NetworkPacket Metatype-capable

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Oct 28 01:03:52 GMT 2018


apol added inline comments.

INLINE COMMENTS

> networkpacket.cpp:60
> +{
> +    m_id = other.m_id;
> +    m_type = other.m_type;

Use the constructor initializers.

> networkpacket.h:52
>  
> -    explicit NetworkPacket(const QString& type, const QVariantMap& body = {});
> +    explicit NetworkPacket(const QString& type = "empty", const QVariantMap& body = {});
> +    NetworkPacket(const NetworkPacket& other); // Copy constructor, required for QMetaType and queued signals

QStringLiteral

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16469

To: sredman, #kde_connect
Cc: apol, nicolasfella, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181028/52b6ae56/attachment-0001.html>


More information about the KDEConnect mailing list