D16470: [WIP] Make incoming packet handling multi-threaded

Simon Redman noreply at phabricator.kde.org
Sat Oct 27 22:58:19 BST 2018


sredman created this revision.
sredman added a reviewer: KDE Connect.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
sredman requested review of this revision.

REVISION SUMMARY
  Data from multiple sources, such as incoming network packets and dbus calls, can currently cause the entire application thread to block if one call needs to wait on another. This diff is the start of moving LanLinkProvider onto its own thread, such that incoming NetworkPackets can be handled independently for different devices and independently of dbus calls. The question at this point is "Do we even want this"?
  
  Current status is that the daemon crashes if the desktop responds to Android's identity broadcast, but if the desktop initiates the connection it works... Until you try to disconnect!
  Packet handling is not actually on its own thread yet

TEST PLAN
  - Build app
  - Connect devices
  - Use as normal (many crashes ensue)

REPOSITORY
  R224 KDE Connect

BRANCH
  multi-thread-link-provider

REVISION DETAIL
  https://phabricator.kde.org/D16470

AFFECTED FILES
  core/backends/lan/lanlinkprovider.cpp
  core/backends/linkprovider.cpp
  core/backends/linkprovider.h
  core/daemon.cpp

To: sredman, #kde_connect
Cc: kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181027/ac8bfac2/attachment-0001.html>


More information about the KDEConnect mailing list