D16092: Make SmsPlugin::requestConversation synchronous and blocking
Simon Redman
noreply at phabricator.kde.org
Wed Oct 10 04:13:51 BST 2018
sredman created this revision.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
sredman requested review of this revision.
REVISION SUMMARY
It was causing many problems to have a method which would return some values if it happend to have them laying around. Now we wait until the messages we need are available before sending a reply.
TEST PLAN
Nothing should visibly change from before:
- Run messaging app
- Verify that conversations are able to be displayed
REPOSITORY
R224 KDE Connect
BRANCH
synchonous-message-fetch
REVISION DETAIL
https://phabricator.kde.org/D16092
AFFECTED FILES
plugins/sms/conversationsdbusinterface.cpp
plugins/sms/conversationsdbusinterface.h
plugins/sms/smsplugin.cpp
plugins/sms/smsplugin.h
smsapp/conversationmodel.cpp
smsapp/conversationmodel.h
To: sredman
Cc: kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181010/6064f0ad/attachment-0001.html>
More information about the KDEConnect
mailing list