D15979: [SMS App] Allow scrolling up to load and display older messages

Nicolas Fella noreply at phabricator.kde.org
Tue Oct 9 16:32:03 BST 2018


nicolasfella added a comment.


  In D15979#337683 <https://phabricator.kde.org/D15979#337683>, @sredman wrote:
  
  > Yes. The issue is the backend only has one message loaded from the phone. When the view first loads it requests the first 10 which causes the backend to request from the phone. Once they're in cache this isn't a problem (try opening the same conversation twice after a slight delay)
  >  I agree this is kind of ugly but I don't know an easy way to fix it. One thought is to make ConversationsDbusInterface::requestConversation synchronous and block until it is able to serve the request. This would be good for several reasons... For one thing, it would enable having multiple conversation views open at the same time!
  
  
  Making it blocking sound like it could cause issues when a device is not reachable. Have you actually tested this?
  When opening the conversation a bunch (10) messages are requested. The problem is that once they arrive the view isn't updated, isn't it?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D15979

To: sredman, #kde_connect
Cc: nicolasfella, kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181009/475ed1f0/attachment.html>


More information about the KDEConnect mailing list