D15979: [SMS App] Allow scrolling up to load and display older messages

Simon Redman noreply at phabricator.kde.org
Sat Oct 6 04:38:21 BST 2018


sredman created this revision.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
sredman requested review of this revision.

REVISION SUMMARY
  Scroll up to show older messages
  
  Newly received messages will not force the view to the bottom unless the new message is being added "very close" to the visible area

TEST PLAN
  Message History:
  
  - Open conversation
  - Scroll/Drag up to load older messages
  
  New Message:
  
  - Open conversation
  - Scroll to bottom
  - Verify that a newly-received or newly-sent message is added to the GUI
  - Scroll up
  - Verify that sending/receiving a message does not disturb the view
  - Scroll back to verify that the new message was indeed added to the list

REPOSITORY
  R224 KDE Connect

BRANCH
  scrollback

REVISION DETAIL
  https://phabricator.kde.org/D15979

AFFECTED FILES
  plugins/sms/conversationsdbusinterface.cpp
  plugins/sms/conversationsdbusinterface.h
  smsapp/conversationmodel.cpp
  smsapp/conversationmodel.h
  smsapp/qml/ConversationDisplay.qml

To: sredman
Cc: kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181006/345342ea/attachment-0001.html>


More information about the KDEConnect mailing list