D17250: Fixed Header in 3 plugin pages: Run Command, Multimedia control, Remote input

Simon Redman noreply at phabricator.kde.org
Fri Nov 30 15:45:01 GMT 2018


sredman requested changes to this revision.
sredman added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> BluetoothPairingHandler.java:55
>      @Override
> -    public void packageReceived(NetworkPacket np) throws Exception {
> +    public void packageReceived(NetworkPacket np) {
>  

Can you say why a lot of methods are no longer throwing? Was it unnecessary to begin with? In any case, it would be best if that change (exceptions) were separated from this change (header fixing)

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D17250

To: brute4s99, #kde_connect, sredman
Cc: albertvaka, sredman, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181130/ee930f6d/attachment.html>


More information about the KDEConnect mailing list