D17224: Make the message TextField expanding, wrapping and scrollable

Simon Redman noreply at phabricator.kde.org
Wed Nov 28 21:34:27 GMT 2018


sredman accepted this revision.
sredman added a comment.
This revision is now accepted and ready to land.


  This looks great! Thanks very much! Just fix the one small issue blocking message sending before merging, please :)

INLINE COMMENTS

> ConversationDisplay.qml:43
> +        console.log("sending sms", page.phoneNumber)
> +        //model.sourceModel.sendReplyToConversation(message.text)
> +        message.text = ""

I am having trouble sending messages with this patch 😂

REPOSITORY
  R224 KDE Connect

BRANCH
  msgtextfield (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17224

To: blaws, #kde_connect, sredman
Cc: sredman, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181128/44227a39/attachment.html>


More information about the KDEConnect mailing list