D17214: GCI [KDE Connect] Start New Conversation in Messaging App

[Nicolas Fella]

nicolasfella requested changes to this revision.
nicolasfella added a comment.
This revision now requires changes to proceed.


  There are some changes in this patch that don't belong here. You probably need to do `git rebase master` to fix it

INLINE COMMENTS

> systemvolumeplugin-pulse.cpp:77
>  
> -    const auto sinks = PulseAudioQt::Context::instance()->sinks();
> -    for (PulseAudioQt::Sink* sink : sinks) {
> +    for (PulseAudioQt::Sink* sink : PulseAudioQt::Context::instance()->sinks()) {
>          sinksMap.insert(sink->name(), sink);

This slipped in by accident. Please remove it

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D17214

To: turx, albertvaka, nicolasfella, sredman, #kde_connect
Cc: kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181128/0e63e09c/attachment.html>