D17125: Title (/Header) in Run Command, Remote Input and Multimedia control was "Remote control". This patch fixes the said Title (/Header) to their respective plugin titles.

Albert Vaca Cintora noreply at phabricator.kde.org
Wed Nov 28 13:19:50 GMT 2018


albertvaka added inline comments.

INLINE COMMENTS

> AndroidManifest.xml:138
>              android:name="org.kde.kdeconnect.Plugins.MprisPlugin.MprisActivity"
> -            android:label="@string/remote_control"
> +            android:label="@string/open_mpris_controls"
>              android:launchMode="singleTop"

Use pref_plugin_mpris for consistency with the others? Or even better, since these strings are not used for preferences anymore, maybe we could call them plugin_mpris_controls, plugin_runcommand, etc. And change the references in the code.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D17125

To: brute4s99, #kde_connect
Cc: albertvaka, sredman, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181128/fd33898e/attachment.html>


More information about the KDEConnect mailing list