D16962: Add mute button with dynamic icon to MPRIS volume control

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> mpris.qml:143
>      }
> +
> +    Component.onCompleted: volumeUnmuted = root.pluginInterface.volume

If you want the property to update instead of just setting the value, use Qt.binding().
http://doc.qt.io/qt-5/qtqml-syntax-propertybinding.html

It could also make sense to use visualPosition.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16962

To: blaws, #kde_connect
Cc: apol, broulik, albertvaka, nicolasfella, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181126/b9d586b1/attachment.html>