D17164: Fix container detach warnings from clazy

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Nov 26 12:11:16 GMT 2018


apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kdeconnect-cli.cpp:156
> +            const auto args = parser.positionalArguments();
> +            for (const QString& input : args) {
>                  QUrl url = QUrl::fromUserInput(input, QDir::currentPath());

Why didn't you use qAsConst here?

REPOSITORY
  R224 KDE Connect

BRANCH
  nodetach

REVISION DETAIL
  https://phabricator.kde.org/D17164

To: nicolasfella, #kde_connect, apol
Cc: apol, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181126/24b854ce/attachment.html>


More information about the KDEConnect mailing list