D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown

[Erik Duisters]

eduisters created this revision.
eduisters added a reviewer: KDE Connect.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
eduisters requested review of this revision.

REVISION SUMMARY
  Combine multiple upload jobs for files into a single KCompositeJob so only 1 notification will be shown
  Includes changes introduced in D16279 <https://phabricator.kde.org/D16279>

TEST PLAN
  1. Share of multiple files is performed using 1 composite job
  
    Setup:
    - Select multiple (big) files in dolphin and share with an Android device Result:
    - The files will be transferred using 1 CompositeUploadJob and showing only 1 notification
  
  2. Share of file while another share is already running adds job to existing composite job
  
    Setup:
    - Select multiple (big) files in dolphin and share with an Android device
    - Share an additional file with the same Android device Result:
    - The files are all transferred using 1 CompositeUploadJob and showing only 1 notification
    - The notification is updated after adding the last file
  
  3. Other packets are transmitted as usual
  
    Setup:
      - Setup sharing desktop notification with device
    - Share a big file with an Android device
    - Generate a desktop notification (eg. sending or receiving an email)
  
      Result:
    - Notification packet is send immediately

REPOSITORY
  R224 KDE Connect

BRANCH
  composite_job_for_uploads

REVISION DETAIL
  https://phabricator.kde.org/D17081

AFFECTED FILES
  cli/kdeconnect-cli.cpp
  core/CMakeLists.txt
  core/backends/lan/CMakeLists.txt
  core/backends/lan/compositeuploadjob.cpp
  core/backends/lan/compositeuploadjob.h
  core/backends/lan/landevicelink.cpp
  core/backends/lan/landevicelink.h
  core/backends/lan/uploadjob.cpp
  core/backends/lan/uploadjob.h
  plugins/share/shareplugin.cpp
  plugins/share/shareplugin.h
  tests/sendfiletest.cpp

To: eduisters, #kde_connect
Cc: kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181121/0accd19e/attachment.html>