D16962: Add mute button with dynamic icon to MPRIS volume control

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> mpris.qml:125
> +                    root.pluginInterface.volume = muted ? 0 : volumeUnmuted
> +                    volumeSlider.enabled = !muted
> +                    icon.name = muted ? "audio-volume-muted" : soundState(root.pluginInterface.volume)

I think you could just set these as bindings rather than programmatically doing it `onClicked`

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16962

To: blaws, #kde_connect
Cc: broulik, albertvaka, nicolasfella, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181120/57257342/attachment.html>