D16962: Add mute button with dynamic icon to MPRIS volume control

Albert Vaca Cintora noreply at phabricator.kde.org
Mon Nov 19 19:22:36 GMT 2018


albertvaka added inline comments.

INLINE COMMENTS

> mpris.qml:135
> +                onValueChanged: {
> +                    volumeUnmuted = root.pluginInterface.volume = value
> +                    muteButton.icon.name = soundState(root.pluginInterface.volume)

This is gonna be more readable in two lines.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16962

To: blaws, #kde_connect
Cc: albertvaka, nicolasfella, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181119/529cd78d/attachment.html>


More information about the KDEConnect mailing list