D17009: QTcpServer already has a list of pending connections and emits newConnection after calling incomingConnection

[Erik Duisters]

eduisters created this revision.
eduisters added a reviewer: KDE Connect.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
eduisters requested review of this revision.

REVISION SUMMARY
  No need to emit newConnection in Server::incomingConnection because QTcpServer will emit it after incomingConnection returns
  QTcpServer also already has a list of pending connections so use that

TEST PLAN
  Send a file from desktop to android and observe that newConnection is only called once

REPOSITORY
  R224 KDE Connect

BRANCH
  new_connection_emitted_twice

REVISION DETAIL
  https://phabricator.kde.org/D17009

AFFECTED FILES
  core/backends/lan/server.cpp
  core/backends/lan/server.h
  core/backends/lan/uploadjob.cpp

To: eduisters, #kde_connect
Cc: kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181119/7d417bae/attachment.html>