D17002: Refactor Duplicated Code in KDE Connect Android-side SMS Helper

Alex Kovrigin noreply at phabricator.kde.org
Mon Nov 19 04:37:48 GMT 2018


alexkovrigin created this revision.
alexkovrigin added a reviewer: sredman.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
alexkovrigin requested review of this revision.

REVISION SUMMARY
  In src/org/kde/kdeconnect/Helpers/SMSHelper.java:
  getMessagesWithFilter() and getConversations() functions are now both using new function: getMessages().

TEST PLAN
  - Build android app and run it on android phone
  - Pair it with the desktop and open sms app (kdeconnect-sms).
  - Everything works as earlier, but now with refactored code.

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17002

AFFECTED FILES
  src/org/kde/kdeconnect/Helpers/SMSHelper.java

To: alexkovrigin, sredman
Cc: sredman, alexkovrigin, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181119/f4df7da9/attachment.html>


More information about the KDEConnect mailing list