D16553: Cache and delete old ConversationsDbusInterfaces to avoid memory leak

[Simon Redman]

sredman added a comment.


  In D16553#358421 <https://phabricator.kde.org/D16553#358421>, @apol wrote:
  
  > This sounds weird, who caches the data? I don't think Qt does any caching, and if it's kde connect, nuking the dbus interface sounds like we're barking up the wrong tree.
  
  
  I'm not sure I understand the question. This plugin (so KDE Connect) is caching the pointer in the static QMap
  
  Ideally we shouldn't have to touch the dbus interface ourselves, and the documentation says it gets taken care of automatically, but that is not happening. You can run the plugin and cause it to load messages to see the unbounded-increasing memory usage (disconnect and reconnect the phone to keep using ever-more memory) or put some debugging in ~ConversationsDbusInterface (and observe that the method is never called without this patch)

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16553

To: sredman, #kde_connect, apol
Cc: apol, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181112/eaa984c7/attachment.html>