D14607: Find my phone runner

[Simon Redman]

sredman added a comment.


  It looks like this patch has a dependency on another one. In my version of the repository, I don't have runners/CMakeLists.txt so this patch doesn't apply

INLINE COMMENTS

> apol wrote in findmyphonerunner.cpp:47
> Can we make this non-blocking? it's not fun when krunner blocks, especially at search.

@nicolasfella In case you don't know where to look, here is an example of how to use QDbusPendingReply: https://cgit.kde.org/kdeconnect-kde.git/tree/smsapp/conversationlistmodel.cpp#n82
It looks like it should be easy to change the code you have to use that style

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D14607

To: nicolasfella, #kde_connect, #plasma, broulik, davidedmundson
Cc: sredman, apol, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181108/d28e640b/attachment.html>