D16712: Load image with resampling to prevent OOM

[Albert Vaca Cintora]

albertvaka requested changes to this revision.
albertvaka added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ShareNotification.java:134
>              } catch (IOException ignored) {
> +            } finally {
> +                if (inputStream != null) {

I think you had an old version of the code when you implemented this, because I changed this finally to a try-with-resources and in your patch this got reverted. Can you rebase it onto the latest master? Apart from that, the patch looks good.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D16712

To: eduisters, #kde_connect, albertvaka
Cc: albertvaka, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181107/70de6be5/attachment.html>