D14607: Find my phone runner

[Aleix Pol Gonzalez]

apol added a comment.


  I think it's a good idea, sorry it took so long to review.

INLINE COMMENTS

> findmyphonerunner.cpp:38
> +    setObjectName(QStringLiteral("Find my device"));
> +    setPriority(AbstractRunner::HighestPriority);
> +}

Highest really?

> findmyphonerunner.cpp:51
> +
> +        for (QString deviceId : devicesReply.value()) {
> +

const &

> findmyphonerunner.cpp:61
> +
> +            if (deviceName.contains(context.query(), Qt::CaseInsensitive) || i18n("Ring").contains(context.query(), Qt::CaseInsensitive) || i18n("Find").contains(context.query(), Qt::CaseInsensitive)) {
> +

These could be filtered already outside of the loop?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D14607

To: nicolasfella, #kde_connect, #plasma, broulik, davidedmundson
Cc: apol, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181107/b3ff2c86/attachment.html>