D16623: [handler] Embed URL into string

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kdeconnect-handler.cpp:102
>      } else {
> -        uidialog.urlLabel->setText(urlToShare.toDisplayString());
> +        displayUrl = urlToShare.toDisplayString(QUrl::PreferLocalFile);
> +        uidialog.label->setText(i18n("Device to open %1 on:", displayUrl));

It doesn't make a lot of sense to PreferLocalFile when we know !isLocalFile

REPOSITORY
  R224 KDE Connect

BRANCH
  handlertext

REVISION DETAIL
  https://phabricator.kde.org/D16623

To: nicolasfella, #kde_connect, apol
Cc: apol, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181103/12f22ecf/attachment.html>