T7994: Extract Qt Pulseaudio bindings into a Framework

David Rosca noreply at phabricator.kde.org
Sat May 26 17:59:03 UTC 2018


drosca added a comment.


  Looks fine, except some issues with methods that should be hidden:
  
  - `Device::updateDevice` should be in private class
  - `Port::setInfo` should be in private class
  - `Profile::setInfo` should be in private class
  - `PulseObject::updatePulseObject` should be in private class
  - `Stream::updateStream` should be in private class
  - `Server::reset` should not be public

TASK DETAIL
  https://phabricator.kde.org/T7994

To: nicolasfella, drosca
Cc: davidedmundson, michaelh, akrutzler, apol, sitter, drosca, #kde_connect, nicolasfella, yannux, Danial0_0, johnq, ragreen, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, ZrenBot, seebauer, ngraham, bruns, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, jensreuterberg, ach, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180526/9a8154fb/attachment.html>


More information about the KDEConnect mailing list