D11854: (WIP) Upgrade Telephony plugin to read SMS history (KDE side)

[Simon Redman]

sredman reopened this revision.
sredman marked 5 inline comments as done.
sredman added a comment.


  In D11854#263216 <https://phabricator.kde.org/D11854#263216>, @andyholmes wrote:
  
  > Would you consider (when you're ready) updating the README to be a little more complete, since you're probably quite familiar with the expected packet formats?
  
  
  Sure. Putting it somewhere centralized is probably a good idea. If you want to look at it now, currently all of that documentation lives in header comments on the various PACKET_TYPE_* fields

INLINE COMMENTS

> apol wrote in telephonyplugin.cpp:53
> Shouldn't this be `!m_telepathyInterface.isValid()`?

No, this is handling the case where the telepathy interface was valid. If the message has been passed to telepathy, it does not keep trying to process it using a notification

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D11854

To: sredman, #kde_connect, nicolasfella, apol
Cc: andyholmes, apol, nicolasfella, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180517/87a60331/attachment.html>