D11854: (WIP) Upgrade Telephony plugin to read SMS history (KDE side)

Simon Redman noreply at phabricator.kde.org
Tue May 15 22:24:15 UTC 2018


sredman updated this revision to Diff 34236.
sredman added a comment.


  Update based on reviews
  
  - Add remaining Telephony Message fields
  - Address review suggestions for const data
  - Correct naming convention of message.Type enum
  - Clean up forwardToTelepathy method
  - Rename sendAllConversationsRequest to requestAllConversations
  - Remove this->
  - Re-add createNotification method
  - Reenable support for old-style packets which generate notificatinos (SMS, incoming call, missed call)
  - Remove extra redundant telepathy code from notifications handling
  - Add header comment to createNotification
  - Add header comment for PACKET_TYPE_TELEPHONY

REPOSITORY
  R224 KDE Connect

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11854?vs=32504&id=34236

BRANCH
  sms-history-rebase

REVISION DETAIL
  https://phabricator.kde.org/D11854

AFFECTED FILES
  interfaces/CMakeLists.txt
  interfaces/dbusinterfaces.cpp
  interfaces/dbusinterfaces.h
  plugins/telephony/CMakeLists.txt
  plugins/telephony/kdeconnect_telephony.json
  plugins/telephony/message.cpp
  plugins/telephony/message.h
  plugins/telephony/telephonyplugin.cpp
  plugins/telephony/telephonyplugin.h

To: sredman, #kde_connect, nicolasfella, apol
Cc: apol, nicolasfella, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180515/2c0ba1d4/attachment.html>


More information about the KDEConnect mailing list