D12878: A little hack to unlock device from android using fingerprint authentication from QS tile

[Nicolas Fella]

nicolasfella added a comment.


  Thanks for the patch! I left some inline comments. It's working good so far, but relying on the unlock command is too hacky IMHO. It should be no problem to port it into a proper plugin with a desktop counterpart that executes the unlocking. You can use the PingPlugin as a template for creating a plugin.

INLINE COMMENTS

> build.gradle:70
>  dependencies {
> -
>      repositories {

Please remove those unrelated changes

> LockHelper.java:180
> +            mCancellationSignal.cancel();
> +            mCancellationSignal = null;
> +        }

Is this really necessary?

> TileService.java:12
> + at TargetApi(Build.VERSION_CODES.N)
> +public class TileService extends android.service.quicksettings.TileService {
> +

Why not import?

> TileService.java:14
> +
> +    private LockHelper mLockHelper = null;
> +

Could Lockhelper become a singleton?

> TileService.java:22
> +        if(isLocked()) {
> +            unlockAndRun(new Runnable() {
> +                @Override

You can use a lambda here

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D12878

To: bhav97
Cc: nicolasfella, kdeconnect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180514/7c05d84e/attachment.html>