D12803: Add detection of Android TV devices with a proper icon

Nicolas Fella noreply at phabricator.kde.org
Thu May 10 11:52:30 UTC 2018


nicolasfella added a comment.


  Thanks for your work!
  
  I don't own an Android TV, so I can't fully test your work, but just by looking at the code it seems reasonable to me. Maybe one of the other developers can do a full test.
  In general, for visible changes it's good practice to attach a screenshot. Have you also tested the look with the dark theme enabled?
  
  About the translation: You did perfectly fine, it will get to the translation team as soon as it is committed.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D12803

To: laissus, #kde_connect
Cc: nicolasfella, kdeconnect, suryatejak, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180510/f932d5bf/attachment.html>


More information about the KDEConnect mailing list