D12670: More RemoteKeyboard cleanup

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> DeviceDelegate.qml:37
> -
> -        onKeyPressReceived: {
> -//            console.log("XXX received keypress key=" + key + " special=" + specialKey + " shift=" + shift + " ctrl=" + ctrl + " text=" + remoteKeyboardInput.text + " cursorPos=" + remoteKeyboardInput.cursorPosition);

Please include the original feature developer to review.

> RemoteKeyboard.qml:61
>      onAvailableChanged: {
> -        if (available) {
> -            remoteKeyboard = RemoteKeyboardDbusInterfaceFactory.create(device.id());
> -            remoteKeyboard.keyPressReceived.connect(keyPressReceived);
> -            remoteKeyboard.remoteStateChanged.connect(remoteStateChanged);
> -        } else {
> -            remoteKeyboard = null
> -        }
> +        remoteKeyboard = available ? RemoteKeyboardDbusInterfaceFactory.create(device.id()) : null;
>      }

Needs destroying the previous remoteKeyboard?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D12670

To: nicolasfella, #kde_connect
Cc: apol, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180502/4eb435ed/attachment-0001.html>