D12670: More RemoteKeyboard cleanup

Nicolas Fella noreply at phabricator.kde.org
Wed May 2 19:41:49 UTC 2018


nicolasfella created this revision.
nicolasfella added a reviewer: KDE Connect.
Restricted Application added a project: KDE Connect.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Drop a lot of code.
  I'm not 100% sure if my thinking is correct, so somebody please confirm it:
  By setting event.accepted = true; we tell Qt to not further process the key event, so it does not reach the text field and thus no text would be displayed. The bunch of code I just deleted works around that and simulates the 
  original behaviour of the text field. By setting event.accepted to false the event reaches the text field and gets processes natively, making the woraround useless.

TEST PLAN
  Type text, move cursor, select/copy/cut/paste text

REPOSITORY
  R224 KDE Connect

BRANCH
  morecleanup

REVISION DETAIL
  https://phabricator.kde.org/D12670

AFFECTED FILES
  plasmoid/package/contents/ui/DeviceDelegate.qml
  plasmoid/package/contents/ui/RemoteKeyboard.qml

To: nicolasfella, #kde_connect
Cc: #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180502/120997a4/attachment-0001.html>


More information about the KDEConnect mailing list