D12618: Add assertions and checks to album art fetch code

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> AlbumArtCache.java:273
>              //Default android behaviour does not follow https -> http urls, so do this manually
> +            if (!url.getProtocol().equals("http") && !url.getProtocol().equals("https")) {
> +                throw new AssertionError("Invalid url: not http(s) in background album art fetch");

Maybe move inside the for loop? currentUrl keeps changing

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  album-art-assertions

REVISION DETAIL
  https://phabricator.kde.org/D12618

To: mtijink, #kde_connect, albertvaka
Cc: albertvaka, #kde_connect, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ahmedbesbes, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180501/77d4c13b/attachment.html>