D9691: Add contacts-reading plugin (KDE side)

[Simon Redman]

sredman added inline comments.

INLINE COMMENTS

> mtijink wrote in contactsplugin.cpp:70
> It's not really common in C++ to write `this->`.

Does it do any harm? It's a habit from writing too much Python (which I'd rather keep so I can still writing Python) and being overly clear never hurt anybody

> mtijink wrote in contactsplugin.h:69
> You can get the uid's by calling `map.keys()`, so the separate list is not needed.

I believe this comment meant to apply somewhere else in the code? But in general I like to give names to things so that other lines are shorter and clearer

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D9691

To: sredman, #kde_connect, apol
Cc: mtijink, #kde_connect, apol, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180330/e3881347/attachment.html>