D11773: New plugin: Find this device

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> apol wrote in findthisdeviceplugin.cpp:61
> I'm not sure it makes sense to send which ringtone needs to be sounding on the other side. Is this how we do it for Android?

This defines the ring tone for this device when being called/pinged, not the other :)

With the Android version this is done the same, cmp. https://phabricator.kde.org/R225:4d5d7449200a240ebc05aa71a60e7f53f03bde7b

Ideally this could be configured once per this device (think family members connecting all their mobiles to the family laptop to be able to find it*), right now it needs to be configured for any connection. But there is no way yet to do such global connection-independent config of a plugin, right?

- And yes, Android KDEConnect also really needs some FindWithMyPhone ;)

> apol wrote in findthisdeviceplugin.cpp:66
> fromLocalFile

I followed here the code from knotification <https://phabricator.kde.org/source/knotifications/browse/master/src/notifybyaudio.cpp;dd633d19201287a67b4f2f139873665b0c194a38$50>  / knotifyconfig <https://phabricator.kde.org/source/knotifyconfig/browse/master/src/knotifyconfigactionswidget.cpp;dbb555c6a2a92f560e99adb2d46b8c3b1a095748$134> which both use QUrl::fromUserInput. See also related commit messages ( 1 <https://phabricator.kde.org/R289:9db06adc8114163f401417064b07772139bc36bc> 2 <https://phabricator.kde.org/R305:4832f7d9f2f3bd0fa8ab9b9162bf50e855efc448>.

Not sure what fancy usages people might have or want to enter, but given the examples in the commit messages, I should be safe to stay consistent with that other code.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D11773

To: kossebau, #kde_connect
Cc: apol, nicolasfella, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180329/696f893f/attachment.html>