D11694: Use theme attributes for appearance of activity_main.xml

Philip Cohn-Cort noreply at phabricator.kde.org
Sun Mar 25 18:32:07 UTC 2018


philipc created this revision.
philipc added a reviewer: KDE Connect.
philipc requested review of this revision.

REVISION SUMMARY
  This revision adds dark mode support to the app ( T7044 <https://phabricator.kde.org/T7044> ). It does so by injecting
  theme information into each activity, and making sure that all Views
  define their colors by reference to theme attributes.
  
  In order to make this work, all of the buttons with images (like the list
  of available devices) now are tinted according to the theme.
  
  While all versions of android support the theme, only devices running
  Android ICS or higher will have a toggle button in the drawer.

TEST PLAN
  Open all the screens, both with and without the dark theme on.

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  feature/dark-theme

REVISION DETAIL
  https://phabricator.kde.org/D11694

AFFECTED FILES
  res/drawable/state_list_drawer_background_dark.xml
  res/layout-v14/nav_dark_mode_switch.xml
  res/layout/activity_main.xml
  res/layout/list_item_with_icon_entry.xml
  res/layout/preference_with_button.xml
  res/values-v21/styles-dark.xml
  res/values/attrs.xml
  res/values/styles-dark.xml
  res/values/styles.xml
  src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java
  src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java
  src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java
  src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java
  src/org/kde/kdeconnect/Plugins/RunCommandPlugin/RunCommandActivity.java
  src/org/kde/kdeconnect/Plugins/SharePlugin/SendFileActivity.java
  src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java
  src/org/kde/kdeconnect/UserInterface/AppCompatPreferenceActivity.java
  src/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java
  src/org/kde/kdeconnect/UserInterface/MainActivity.java
  src/org/kde/kdeconnect/UserInterface/ThemeUtil.java

To: philipc, #kde_connect
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180325/4069452a/attachment.html>


More information about the KDEConnect mailing list