D7993: System volume plugin Android

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> mtijink wrote in mpris_control.xml:162
> Does this work if the system volume plugin is disabled?

Yes, as the class still exists. The Activity handles a not loaded systemvolumeplugin gracefully

> mtijink wrote in strings.xml:239
> I'd drop the colon.

I don't need it at all

> mtijink wrote in MprisActivity.java:95
> Should use a check if it's available.

I do that in the fragment

> mtijink wrote in Sink.java:90
> No `setMaxVolume`?

Maybe someday

> mtijink wrote in SystemvolumeFragment.java:105
> What about old sinks? Now you're subscribing twice.

addListener checks for that

> mtijink wrote in SystemvolumeFragment.java:135
> Shouldn't it display 0 volume if it's muted?

No, muting is orthogonal to the actual volume. Plasma-pa behaves the same

> mtijink wrote in SystemvolumePlugin.java:74
> You can use a for in loop.

JSONArray doesn't really support that

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D7993

To: nicolasfella, #kde_connect, mtijink
Cc: Murz, mtijink, #kde_connect, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180325/b08316eb/attachment.html>