D10703: Build kdeconnect on sailfish and port some simple plugins

Albert Vaca Cintora noreply at phabricator.kde.org
Fri Mar 23 18:58:52 UTC 2018


albertvaka requested changes to this revision.
albertvaka added inline comments.

INLINE COMMENTS

> pluginloader.cpp:34
> +#include "qtcompat_p.h"
> +#endif
> +

Can we target latest Sailfish, so we don't need to keep compatibility with Qt 5.6?

> apol wrote in sendnotificationsplugin.cpp:29
> There should be. Having this line is ugly as is, let alone having to ifdef it on every plugin.

+1

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D10703

To: piggz, #kde_connect, apol, mtijink, nicolasfella, albertvaka
Cc: andyholmes, albertvaka, kossebau, mtijink, vonreth, apol, #kde_connect, nicolasfella, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180323/913afe4f/attachment.html>


More information about the KDEConnect mailing list