D11018: Support file url album art - Android

[Albert Vaca Cintora]

albertvaka added inline comments.

INLINE COMMENTS

> AlbumArtCache.java:352
> +        if (url.getProtocol().equals("file")) {
> +            for (MprisPlugin mpris : registeredPlugins) {
> +                if (mpris.askTransferAlbumArt(url.toString())) {

I find it a bit weird to query all MPRIS plugins for the art, and then in askTransferAlbumArt check if you hit the right plugin... Isn't there a way to pass the plugin that you know has the art to this function?

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D11018

To: mtijink, #kde_connect, nicolasfella
Cc: albertvaka, nicolasfella, #kde_connect, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180319/a1e68d84/attachment.html>