D11438: Use a shared pointer for keeping track of notifications

[Matthijs Tijink]

mtijink created this revision.
mtijink added a reviewer: KDE Connect.
mtijink requested review of this revision.

REVISION SUMMARY
  Previously commit 895a9206ffafd4b9725 <https://phabricator.kde.org/R224:895a9206ffafd4b9725f567fd069fd655f200139> tried to fix the issues of
  already-freed notifications by using a QPointer. This only sets the
  pointer to null when deleted. Thus, commit 6495e8dc538610fb67 <https://phabricator.kde.org/R224:6495e8dc538610fb679df0f1522243103a3a1789> was needed
  too.
  
  I tried to fix this here with a shared pointer, hopefully fixing bug 389518.

TEST PLAN
  Receiving notifications still works fine for me.

REPOSITORY
  R224 KDE Connect

BRANCH
  notifications-shared-ptrs

REVISION DETAIL
  https://phabricator.kde.org/D11438

AFFECTED FILES
  plugins/notifications/notification.h
  plugins/notifications/notificationsdbusinterface.cpp
  plugins/notifications/notificationsdbusinterface.h

To: mtijink, #kde_connect
Cc: #kde_connect
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180317/8b54d14a/attachment.html>