D10779: Split MousepadPlugin into X11 and Wayland plugin

Albert Vaca Cintora noreply at phabricator.kde.org
Thu Mar 15 19:46:11 UTC 2018


albertvaka requested changes to this revision.
albertvaka added a comment.
This revision now requires changes to proceed.


  I don't like having two plugins doing the same. I really like removing the ifdefs, though, and having code for each platform on a different file. Can we do this inside a same plugin?
  
  We could have a mousepadplugin that instantiates one specific implementation class within it, depending on the platform (wayland/X11/windows/macosx/whatever), instead of N different plugins.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D10779

To: nicolasfella, #kde_connect, graesslin, albertvaka
Cc: albertvaka, apol, graesslin, #kde_connect, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180315/008d622b/attachment.html>


More information about the KDEConnect mailing list