D10972: [RFC] Exposing slideshow to MPRIS controllers

[Henrik Fehlauer]

rkflx added a comment.


  In D10972#226099 <https://phabricator.kde.org/D10972#226099>, @kossebau wrote:
  
  > Will edit the commit message into something, do you want to review the text first? Would text follwing the one of D11250 <https://phabricator.kde.org/D11250> work for you?
  
  
  Oh, I was just thinking about cleaning up "RFC", "Questions" etc., nothing fancy ;)
  
  >> There's now also T8222: Improve MPRIS support <https://phabricator.kde.org/T8222> where I added some of the things which could be solved later, so they are not forgotten and interested contributors can jump right in. Feel free to add to this (but please keep it concise) or add subtasks.
  > 
  > Okay. Might make sense to copy the phab T numbers then in the respective code comments, so people can find things both ways?
  
  Your call, but why not. #gwenview <https://phabricator.kde.org/tag/gwenview/>'s workboard is quite new, so there's not really a precedence.

INLINE COMMENTS

> kossebau wrote in mprismediaplayer2.cpp:82
> Ah, missed the Qt 5.6 min dep, right.
> 
> https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry says that "[t]This property is optional.".
> 
> So I would  simply "if version > 5.6" this part, okay?

Yup.

REPOSITORY
  R260 Gwenview

BRANCH
  addmprisservice

REVISION DETAIL
  https://phabricator.kde.org/D10972

To: kossebau, #gwenview, rkflx
Cc: mtijink, ngraham, nicolasfella, #kde_connect, rkflx, broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180315/59b6a86b/attachment.html>