Crash receiving notifications icons

[Nicolas Fella]

Hi Albert,

I observed this as well and came to a similar analysis, but i don't know
how to fix that either. In fact, https://phabricator.kde.org/D10089 tried
to fix it. I tried to implement a List of ongoing file transfers and check
if a file is being transferred, but I couldn't make it work.


On Mar 12, 2018 22:38, "Albert Vaca" <albertvaka at gmail.com> wrote:

Ok, looks like the update() method of the notification is called several
times, and each time it does:

The icon file exists?
Nope -> Then create a download job for it

The downloadjob will create the file, but it is async. Hence, the second
time update is called, the icon still doesn't exist and a new downloadjob
is created.

We need to make sure that the second time update is called, we don't try to
download again something that is already in the process of being download.

Not sure how to do it, though :D

Also, would be nice if update doesn't get called several times in a row.

Albert


On Mon, Mar 12, 2018 at 10:21 PM, Albert Vaca <albertvaka at gmail.com> wrote:

> It seems that the download is triggered several times.
>
> The first one succeeds, the second one fails, the third one fails and
> crashes KDE Connect.
>
> Any idea why this happens?
>
> kdeconnect.core: FileTransferJob Downloading payload to
> QUrl("file:///tmp/kdeconnect_vaka/d991fcc0a831069ef692586af8efbd84")
> size: 22175
> kdeconnect.core: FileTransferJob Downloading payload to
> QUrl("file:///tmp/kdeconnect_vaka/d991fcc0a831069ef692586af8efbd84")
> size: 22175
> kdeconnect.core: FileTransferJob Downloading payload to
> QUrl("file:///tmp/kdeconnect_vaka/d991fcc0a831069ef692586af8efbd84")
> size: 22175
> kdeconnect.core: FileTransferJob Downloading payload to
> QUrl("file:///tmp/kdeconnect_vaka/d991fcc0a831069ef692586af8efbd84")
> size: 22175
> kdeconnect.core: Finished transfer QUrl("file:///tmp/kdeconnect_v
> aka/d991fcc0a831069ef692586af8efbd84")
> kdeconnect.core: Couldn't transfer the file successfully
> QNetworkReply::NetworkError(UnknownNetworkError)
> "/tmp/kdeconnect_vaka/d991fcc0a831069ef692586af8efbd84"
> kdeconnect.plugin.notification: Error in FileTransferJob:  "Received
> incomplete file: /tmp/kdeconnect_vaka/d991fcc0a831069ef692586af8efbd84"
> kdeconnect.core: Finished transfer QUrl("file:///tmp/kdeconnect_v
> aka/d991fcc0a831069ef692586af8efbd84")
> kdeconnect.plugin.notification: Error in FileTransferJob:  "Received
> incomplete file: /tmp/kdeconnect_vaka/d991fcc0a831069ef692586af8efbd84"
> Segmentation fault (core dumped)
>
>
> Albert
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180312/c82f70fc/attachment.html>