D10972: [RFC] Exposing slideshow to MPRIS controllers

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> rkflx wrote in mprismediaplayer2.cpp:46-49
> Is there a fundamental reason for that, or is this just a `TODO`?
> 
> Also wouldn't it be good to call this upon "Play"?

More a TODO, had not yet started to think about how and where this could be useful. Also not yet seen how existing controllers make use of this feature.

To call this on "Play" would be a decision of the controller. From my reading of the spec this seems more about bringing any specific media app controller UI onto the screen, not the actually rendered media (though usually apps have the bundled in their UI). But room for interpretation. Then in Wayland apps might not be able to autoraise their windows.

Added an explicit todo comment now, so  future code reader can continue from here.

> rkflx wrote in mprismediaplayer2.cpp:51-57
> Why is this connected to the notion of a (auto-advancing) slideshow? If this is only about a fullscreen toggle, this could be set to `true`. Switching tracks already works fine in windowed mode.
> 
> In windowed mode, it would probably still make sense to make the "Play" action enter fullscreen like the corresponding "Start Slideshow" action in Gwenview does (see other part of the reply).
> 
> Conversely, switching back to windowed mode from fullscreen should stop the slideshow, just like Gwenview does.

It was connected to things as by my initial mind model of gwenview states :)

https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:Fullscreen does not specify whether requesting a change of fullscreen state should result also in playbackmodus change, so should be fine to do as you prefer.

Not aware of an controllers which make use of this, so only tested via qtdbusviewer.

> rkflx wrote in mprismediaplayer2.h:20-21
> `MPRISMEDIAPLAYER2_H`?

Was some last trace of this feature patch some years ago initially drated for Calligra Stage (which uses KPR from former KPresenter name as prefix :) )

> rkflx wrote in mprismediaplayer2player.cpp:270
> Would it be possible to include the folder name somewhere?

The folder name could be mapped onto "xesam:album" semantics instead of the "Gwenview Slideshow". What would be a good source to read the folder name from?

REPOSITORY
  R260 Gwenview

REVISION DETAIL
  https://phabricator.kde.org/D10972

To: kossebau, #gwenview
Cc: mtijink, ngraham, nicolasfella, #kde_connect, rkflx, broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180312/27826739/attachment-0001.html>