D11104: Add a method for creating simple notifications

Wed Mar 7 01:02:32 UTC 2018

apol added a comment.

  Makes a lot of sense to me.

  Seems you can remove the CMake parts of these? i.e. not linking to KF5::Notifications and not find_package(KF5Notifications)

INLINE COMMENTS

> kdeconnectd.cpp:73
> +    {
> +        qDebug() << "Creating notification";
> +        KNotification* notification = new KNotification(eventId); //KNotification::Persistent

use qCDebug.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D11104

To: piggz, kdeconnect, apol
Cc: kdeconnect
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180307/b8d67681/attachment.html>