D10703: Build kdeconnect on sailfish and port some simple plugins

Adam Pigg noreply at phabricator.kde.org
Sun Mar 4 09:33:11 UTC 2018


piggz added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:33
> Why?

See above, the nemo notification library uses signal/slot terminology, so requires this.  Normal builds retain -DQT_NO_KEYWORDS

> apol wrote in daemon.cpp:44
> You may be interested in this:
> https://cgit.kde.org/kdevelop.git/tree/kdevplatform/qtcompat_p.h

Ive replaced my version with the one from kdevelop

> mtijink wrote in kdeconnect-sfos.changes.in:1
> I don't think rpm files normally live inside a KDE application repository. Is it possible to maintain these files in a separate repository?

Ok, i'll remove the rpm files, and put them on the mer obs instead

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D10703

To: piggz, #kde_connect, apol, mtijink
Cc: kossebau, mtijink, vonreth, apol, #kde_connect, nicolasfella, vhyvert, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, aboudhar, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180304/fdf37bbd/attachment.html>


More information about the KDEConnect mailing list