D10949: Clean up CustomDevicesActivity

Matthijs Tijink noreply at phabricator.kde.org
Sat Mar 3 14:31:55 UTC 2018


mtijink requested changes to this revision.
mtijink added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CustomDevicesActivity.java:162
>      public static String serializeIpList(ArrayList<String> ipList) {
> -        String serialized = "";
> +        StringBuilder serialized = new StringBuilder();
>          for (String ipAddress : ipList) {

The whole list can be joined using `String.join()`

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D10949

To: nicolasfella, #kde_connect, mtijink
Cc: mtijink, #kde_connect, vhyvert, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180303/2ec3d60d/attachment.html>


More information about the KDEConnect mailing list