D10981: Correctly handle changing canPlay, canPause, canGoNext and canGoPrevious
Nicolas Fella
noreply at phabricator.kde.org
Fri Mar 2 22:38:00 UTC 2018
nicolasfella created this revision.
nicolasfella added a reviewer: KDE Connect.
nicolasfella added a project: KDE Connect.
nicolasfella requested review of this revision.
REVISION SUMMARY
Gwenview is adding MPRIS support in D10972 <https://phabricator.kde.org/D10972>. I tested it and noticed that it was quite buggy. Turns out,
Gwenviews implementation is (almost) fine, the problem was on our side. Unlike pure music players like
Spotify Gwenview changes canPlay, canPause, canGoNext and canGoPrevious when needed, but those updates
didn't reach our UI. The packages containing those updates were not parsed because they didn't contain
several fields.
TEST PLAN
Controlling Spotify and Gwenview (patched to support playPause) works fine now.
REPOSITORY
R225 KDE Connect - Android application
BRANCH
mprisfix
REVISION DETAIL
https://phabricator.kde.org/D10981
AFFECTED FILES
src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java
To: nicolasfella, #kde_connect
Cc: #kde_connect, vhyvert, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180302/f64b5f97/attachment.html>
More information about the KDEConnect
mailing list